alamb commented on PR #11292: URL: https://github.com/apache/datafusion/pull/11292#issuecomment-2212419096
> Thanks for review and merge, @alamb ! RustRover has nice inspections and can detect unnecessary use of qualified names. Sadly it can't fix them automatically (yet), so it's currently manual & requires proper review. Thank you I also also use Rust Rover and it is quite nice. I think everything we can do to help keep the code easier to read / understand / maintain is great > That's why I fixed only some of these. Another strategy I have found sometimes works well is to write a ticket describing the additional work -- often there are other contributors who will make PRs to do it. It works especially well if you have an example PR like this. I filed https://github.com/apache/datafusion/issues/11317 for this one -- let's see if anyone is interested in working on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
