comphead commented on PR #553:
URL: https://github.com/apache/datafusion-comet/pull/553#issuecomment-2161427643

   just checked DF on one of the failed queries
   
   ```
   #[tokio::test]
       async fn test_smj_left_filtered() -> Result<()> {
           let ctx: SessionContext = SessionContext::new();
   
           let sql = "set datafusion.optimizer.prefer_hash_join = false;";
           let _ = ctx.sql(sql).await?.collect().await?;
   
           let sql = "set datafusion.execution.batch_size = 100";
           let _ = ctx.sql(sql).await?.collect().await?;
   
           let sql = "
               select * from (
               with t as (
                   select id, id % 5 id1 from (select unnest(range(0,10)) id)
               ), t1 as (
                   select id % 10 id, id + 2 id1 from (select 
unnest(range(0,10)) id)
               )
               select * from  t left join  t1 on t.id1 = t1.id and t.id > t1.id1
               ) order by 1, 2, 3, 4
           ";
   
           let actual = ctx.sql(sql).await?.collect().await?;
   
           let expected: Vec<&str> = vec![
               "+----+-----+----+-----+",
               "| id | id1 | id | id1 |",
               "+----+-----+----+-----+",
               "| 0  | 0   |    |     |",
               "| 1  | 1   |    |     |",
               "| 2  | 2   |    |     |",
               "| 3  | 3   |    |     |",
               "| 4  | 4   |    |     |",
               "| 5  | 0   | 0  | 2   |",
               "| 6  | 1   | 1  | 3   |",
               "| 7  | 2   | 2  | 4   |",
               "| 8  | 3   | 3  | 5   |",
               "| 9  | 4   | 4  | 6   |",
               "+----+-----+----+-----+",
           ];
           datafusion_common::assert_batches_eq!(expected, &actual);
   
           Ok(())
       }
   ```
   
   it passes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to