andygrove commented on code in PR #691:
URL: https://github.com/apache/datafusion-python/pull/691#discussion_r1600065764
##########
src/expr.rs:
##########
@@ -558,41 +553,9 @@ impl PyExpr {
}
})
}
-
- pub fn column_name(&self, plan: PyLogicalPlan) -> PyResult<String> {
- self._column_name(&plan.plan()).map_err(py_runtime_err)
- }
}
impl PyExpr {
Review Comment:
It looks like Dask SQL is using a pinned version of this repo from more than
six months ago, so we likely won't get a review from the team right away. The
new functionality based on `Field` looks good to me, so I will go ahead and
merge this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
