piyushka-ally commented on code in PR #49590:
URL: https://github.com/apache/arrow/pull/49590#discussion_r3033302837
##########
python/pyarrow/tests/test_feather.py:
##########
@@ -882,3 +889,44 @@ def
test_feather_datetime_resolution_arrow_to_pandas(tempdir):
assert expected_0 == result['date'][0]
assert expected_1 == result['date'][1]
+
+
+# --- Deprecation warning tests ---
+
[email protected]
Review Comment:
The @pytest.mark.pandas is there because read_feather calls .to_pandas()
internally, so the test would fail in environments without pandas installed.
write_feather and read_table don't need it, but read_feather does. Should I
split this back into two tests, one without the pandas mark for
write_feather/read_table, and a separate pandas-marked one for read_feather? Or
would you prefer a different approach?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
