raulcd commented on code in PR #49603:
URL: https://github.com/apache/arrow/pull/49603#discussion_r3020372431
##########
.github/workflows/cpp_extra.yml:
##########
@@ -668,39 +740,6 @@ jobs:
remote_key: ${{ secrets.NIGHTLIES_RSYNC_KEY }}
remote_host_key: ${{ secrets.NIGHTLIES_RSYNC_HOST_KEY }}
- odbc-release:
Review Comment:
We do it on the Linux packaging ones. We trigger the job on tag creation:
https://github.com/apache/arrow/blob/92734673d1c9dea033fb30844278d321e82a7874/.github/workflows/package_linux.yml#L38-L39
We wait until the Release is created on GitHub so we can use the tar.gz from
the release:
https://github.com/apache/arrow/blob/92734673d1c9dea033fb30844278d321e82a7874/.github/workflows/package_linux.yml#L228-L235
And we only upload to the release:
https://github.com/apache/arrow/blob/92734673d1c9dea033fb30844278d321e82a7874/.github/workflows/package_linux.yml#L288-L295
Some of those steps are only done in the case of tag trigger (so only on
RCs).
I think we should use a similar pattern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
