liamzwbao commented on code in PR #9497:
URL: https://github.com/apache/arrow-rs/pull/9497#discussion_r3019374723
##########
arrow-json/src/reader/run_end_array.rs:
##########
@@ -56,64 +60,39 @@ impl<R: RunEndIndexType> RunEndEncodedArrayDecoder<R> {
}
impl<R: RunEndIndexType + Send> ArrayDecoder for RunEndEncodedArrayDecoder<R> {
- fn decode(&mut self, tape: &Tape<'_>, pos: &[u32]) -> Result<ArrayData,
ArrowError> {
+ fn decode(&mut self, tape: &Tape<'_>, pos: &[u32]) -> Result<ArrayRef,
ArrowError> {
let len = pos.len();
if len == 0 {
- return Ok(new_empty_array(&self.data_type).to_data());
+ return Ok(new_empty_array(&self.data_type));
}
- let flat_data = self.decoder.decode(tape, pos)?;
+ let flat_array = self.decoder.decode(tape, pos)?;
Review Comment:
Revert the REE optimization, will fix the partition API and reimplement the
optimization later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
