liamzwbao commented on code in PR #9631:
URL: https://github.com/apache/arrow-rs/pull/9631#discussion_r3016420557
##########
parquet-variant-compute/src/variant_to_arrow.rs:
##########
@@ -585,10 +585,17 @@ impl<'a> StructVariantToArrowRowBuilder<'a> {
}
impl<'a> ArrayVariantToArrowRowBuilder<'a> {
+ /// Creates a new list builder for the given data type.
+ ///
+ /// # Arguments
+ /// * `shredded` - If true, element builders produce shredded structs with
`value`/`typed_value`
+ /// fields (for [`crate::shred_variant()`]). If false, element builders
produce strongly typed
+ /// arrays directly (for [`crate::variant_get()`]).
pub(crate) fn try_new(
Review Comment:
From the current impl, the struct builders aren't as straightforward to
consolidate as the list builders were. Created an issue #9633 to keep track of
the refactor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
