raulcd commented on code in PR #47623:
URL: https://github.com/apache/arrow/pull/47623#discussion_r2378526746
##########
cpp/src/arrow/filesystem/azurefs_test.cc:
##########
@@ -423,8 +423,11 @@ class TestGeneric : public ::testing::Test, public
GenericFileSystemTest {
class TestAzuriteGeneric : public TestGeneric {
public:
void SetUp() override {
- ASSERT_OK_AND_ASSIGN(auto env, AzuriteEnv::GetInstance());
- SetUpInternal(env);
+ auto env_result = AzuriteEnv::GetInstance();
+ if (!env_result.ok()) {
+ GTEST_SKIP() << "Failed to setup: " << env_result.status().ToString();
Review Comment:
Thanks @kou I think I prefer the second approach so at least we have the
safeguard of the macOS cpp job that installs azurite to fail if the
`install_azurite.sh` script starts silently failing again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
