friendlymatthew commented on PR #7808: URL: https://github.com/apache/arrow-rs/pull/7808#issuecomment-3015640662
I envision two main use cases for variant-- 1) building up objects with a known schema (schema on write) and 2) building up objects with an unknown schema (schema on read). - `bench_object_list_same_schemas` builds up a list of objects with the same field names with random values - `bench_object_list_unknown_schema` builds up a list of objects with _random_ field names with random values I also included `bench_object_field_names_reverse_order`. This case builds an object with field names inserted in the reverse lexicographical order. I think this is interesting because we can test the sorting behavior in `ObjectBuilder::finish`. I ran benchmarks locally, and I observed a general improvement in performance. <img width="739" alt="Screenshot 2025-06-28 at 11 51 55 AM" src="https://github.com/user-attachments/assets/2c1aa52b-393f-4222-8bf0-33e7017eb725"; /> `bench_object_list_same_schemas` seems to have a small regression, but it's not very much above noise and the much larger improvements to the other flows make me not too concerned about it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
