EnricoMi commented on code in PR #44083:
URL: https://github.com/apache/arrow/pull/44083#discussion_r1824401563
##########
python/pyarrow/acero.py:
##########
@@ -311,13 +313,18 @@ def _perform_join_asof(left_operand, left_on, left_by,
# Add the join node to the execplan
if isinstance(left_operand, ds.Dataset):
- left_source = _dataset_to_decl(left_operand, use_threads=use_threads)
+ left_source = _dataset_to_decl(
+ left_operand,
+ use_threads=use_threads,
+ require_sequenced_output=True)
else:
left_source = Declaration(
"table_source", TableSourceNodeOptions(left_operand),
)
if isinstance(right_operand, ds.Dataset):
- right_source = _dataset_to_decl(right_operand, use_threads=use_threads)
+ right_source = _dataset_to_decl(
+ right_operand, use_threads=use_threads,
+ require_sequenced_output=True)
Review Comment:
Do you really need the dataset to be sequenced? I think all you need is
implicit ordering (batch indices) so you can sequence the batches at any point
down the pipeline (by your asof join node).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
