zeroshade commented on code in PR #40284:
URL: https://github.com/apache/arrow/pull/40284#discussion_r1509627880
##########
cpp/src/arrow/flight/sql/server_session_middleware.cc:
##########
@@ -80,7 +80,7 @@ class ServerSessionMiddlewareImpl : public
ServerSessionMiddleware {
Status CloseSession() override {
const std::lock_guard<std::shared_mutex> l(mutex_);
- if (static_cast<bool>(session_)) {
+ if (!static_cast<bool>(session_)) {
Review Comment:
I think this is a good discussion potentially but I agree that this is an
issue scoped to the implementation, which doesn't seem to be an issue for us on
the Go side currently. I'm going to merge this as it looks pretty well covered
and handled to me here but feel free to continue this discussion even with this
PR merged if desired.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
