indigophox commented on code in PR #40284:
URL: https://github.com/apache/arrow/pull/40284#discussion_r1508316968
##########
cpp/src/arrow/flight/sql/server_session_middleware.cc:
##########
@@ -80,7 +80,7 @@ class ServerSessionMiddlewareImpl : public
ServerSessionMiddleware {
Status CloseSession() override {
const std::lock_guard<std::shared_mutex> l(mutex_);
- if (static_cast<bool>(session_)) {
+ if (!static_cast<bool>(session_)) {
Review Comment:
@joellubi is correct here and the fix also checks out. Looks like from my
commit history that I typoed this while hastily updating the code to work
around and omit functionality affected by #40071. This used to be covered in
integration testing but was temporarily removed as the aforementioned issue
breaks the ability (in C++) to correctly invalidate sessions (on the server
side) when the CloseSession Action is called.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
