zhangbutao commented on code in PR #6267: URL: https://github.com/apache/hive/pull/6267#discussion_r3068014651
########## standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/CatalogUtil.java: ########## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hive.metastore; + +import org.apache.commons.lang3.EnumUtils; + +import java.util.EnumSet; +import java.util.Set; + +public class CatalogUtil { + public enum CatalogType { + NATIVE, Review Comment: We had some discussion in the document: https://docs.google.com/document/d/1SX8OPd_KdBuynMr-D8AZ7V5tKkoUDKFterUSjeRpOW0/edit?disco=AAAB2orynk4 Wechar @wecharyu gave a good discussion: > Also, since both native and hive point to Hive tables, it might be cleaner to unify them as type = hive, and use another field to distinguish local HMS vs external HMS. > > In this way it might be clearer to separate “catalog type” from “catalog scope / connectivity”, and type consistently represents the data source now. So I’m considering: for the internal HMS catalog, should we use the "native" type or the "hive" type? If we use the "hive" type for native hms catalog, then the main difference between a remote/external Hive catalog and a native/internal Hive catalog would be whether the `external` keyword is present when creating the catalog. @deniskuzZ What do you think — should we unify remote and internal Hive catalogs to both use the "hive" type? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
