ayushtkn commented on code in PR #6408:
URL: https://github.com/apache/hive/pull/6408#discussion_r3053650978
##########
ql/src/test/org/apache/hadoop/hive/ql/io/parquet/VectorizedColumnReaderTestBase.java:
##########
@@ -317,14 +317,15 @@ protected static void writeData(ParquetWriter<Group>
writer, boolean isDictionar
g.addGroup("nsf").append("c", intVal).append("d", intVal);
g.append("e", doubleVal);
- Group some_null_g = group.addGroup("struct_field_some_null");
- if (i % 2 != 0) {
- some_null_g.append("f", intVal);
- }
- if (i % 3 != 0) {
- some_null_g.append("g", doubleVal);
+ if (i % 6 != 0) {
+ Group some_null_g = group.addGroup("struct_field_some_null");
Review Comment:
Ouch. I missed it, let me fix it in next iter to `struct_field_with_null`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
