rtrivedi12 commented on code in PR #6381:
URL: https://github.com/apache/hive/pull/6381#discussion_r3049565015
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/datasource/HikariCPDataSourceProvider.java:
##########
@@ -51,6 +53,8 @@ public DataSource create(Configuration hdpConfig, int
maxPoolSize) throws SQLExc
String passwd = DataSourceProvider.getMetastoreJdbcPasswd(hdpConfig);
Properties properties =
replacePrefix(DataSourceProvider.getPrefixedProperties(hdpConfig, HIKARI));
+ // connectionTimeout is handled separately with getTimeDuration()
+ properties.remove("connectionTimeout");
Review Comment:
Sure, it makes sense! Do you suggest including other time configs like idle
connection timeout etc to include in this map as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
