deniskuzZ commented on code in PR #6379:
URL: https://github.com/apache/hive/pull/6379#discussion_r3045753554
##########
llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestCacheContentsTracker.java:
##########
@@ -136,7 +135,7 @@ public void testEncodingDecoding() throws Exception {
partDescs.clear();
partDescs.put("mutli=one", "one=/1");
partDescs.put("mutli=two/", "two=2");
- tag = CacheTag.build("math.rules", partDescs);
+ tag = CacheTag.build(Warehouse.DEFAULT_CATALOG_NAME + ".math.rules",
partDescs);
Review Comment:
why not handle DEFAULT_CATALOG_NAME inside `CacheTag.build` when size ==2?
you wouldn't need CacheTag.build(Warehouse.DEFAULT_CATALOG_NAME,
"math.rules") either
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
