ashniku commented on code in PR #6412:
URL: https://github.com/apache/hive/pull/6412#discussion_r3044647059
##########
itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java:
##########
@@ -2662,6 +2682,10 @@ public void testQueryTimeout() throws Exception {
fail("Expecting SQLTimeoutException");
} catch (SQLTimeoutException e) {
assertNotNull(e);
+ assertTrue("Message should reflect JDBC query timeout (1s): " +
e.getMessage(),
Review Comment:
Introduced constant QUERY_TIMED_OUT_AFTER_1_SECONDS = "Query timed out after
1 seconds" with Javadoc that this is the full message from HS2 / client (no
query id, host, timestamp in that string for these paths).
testQueryTimeout now uses assertEquals, expected value = that constant, with
a failure message that repeats the example text.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
