mdayakar commented on code in PR #6405:
URL: https://github.com/apache/hive/pull/6405#discussion_r3036894973
##########
hplsql/src/main/java/org/apache/hive/hplsql/Exec.java:
##########
@@ -1037,11 +1037,13 @@ public void printExceptions() {
} else if (sig.type == Signal.Type.VALIDATION) {
error(((HplValidationException)sig.exception).getCtx(),
sig.exception.getMessage());
} else if (sig.type == Signal.Type.SQLEXCEPTION) {
- console.printError("Unhandled exception in HPL/SQL");
+ console.printError("Unhandled exception in HPL/SQL: " + sig.value);
} else if (sig.type == Signal.Type.UNSUPPORTED_OPERATION) {
console.printError(sig.value == null ? "Unsupported operation" :
sig.value);
} else if (sig.exception != null) {
console.printError("HPL/SQL error: " +
ExceptionUtils.getStackTrace(sig.exception));
+ } else if (sig.type == Signal.Type.LEAVE_PROGRAM) {
+ console.printError("Leaving Program: " + sig.value);
Review Comment:
I don't think it will make any difference, anyway both will be written on
the beeline console. Here user explicitly calling QUIT so I also feel it can't
be written on the error stream so changed accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
