shubhluck commented on code in PR #6382:
URL: https://github.com/apache/hive/pull/6382#discussion_r3035762773
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java:
##########
@@ -1977,8 +1977,9 @@ private void
removeSemijoinOptimizationByBenefit(OptimizeTezProcContext procCtx)
LOG.debug("Old stats for {}: {}", roi.filterOperator,
roi.filterStats);
LOG.debug("Number of rows reduction: {}/{}", newNumRows,
roi.filterStats.getNumRows());
}
+ boolean useColStats = roi.filterStats.getColumnStats() != null;
StatsUtils.updateStats(roi.filterStats, newNumRows,
- true, roi.filterOperator, roi.colNames);
+ useColStats, roi.filterOperator, roi.colNames);
Review Comment:
Thank you @zabetak, for your patience in reviewing this. Based on your
feedback, I’ve kept the changes minimal and updated the test accordingly.
The test fix sets hive.auto.convert.join=false, which forces reduce-side
joins and results in semi-join branches. The EXPLAIN output now includes
in_bloom_filter and bloom_filter operators, confirming that
removeSemijoinOptimizationByBenefit is triggered with non-zero
SemiJoinBranchInfo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
