okumin commented on code in PR #6387:
URL: https://github.com/apache/hive/pull/6387#discussion_r3035254535
##########
.github/workflows/docker-images.yml:
##########
@@ -87,10 +89,18 @@ jobs:
- name: Prepare common environment variables
run: |
echo "namespace=${{ vars.DOCKER_NAMESPACE || 'apache' }}" >>
$GITHUB_ENV
- echo "tag=$HIVE_VERSION" | awk '{print tolower($0)}' >> $GITHUB_ENV
+ echo "tag=$HIVE_VERSION" >> $GITHUB_ENV
+
+ - name: Validate nightly tag suffix
+ if: github.event_name == 'schedule'
+ run: |
+ if [[ "$tag" != *-SNAPSHOT ]]; then
+ echo "Nightly image tag must end with -SNAPSHOT, got: $tag"
+ exit 1
+ fi
Review Comment:
```
% cat /tmp/validate.sh
#!/bin/bash
tag=$1
if [[ "$tag" != *-SNAPSHOT ]]; then
echo "Nightly image tag must end with -SNAPSHOT, got: $tag"
exit 1
fi
% bash /tmp/validate.sh '4.3.0'
Nightly image tag must end with -SNAPSHOT, got: 4.3.0
% echo $?
1
% bash /tmp/validate.sh '4.3.0-SNAPSHOT'
% echo $?
0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
