okumin commented on code in PR #6398:
URL: https://github.com/apache/hive/pull/6398#discussion_r3027739743
##########
ql/pom.xml:
##########
@@ -166,6 +166,11 @@
<groupId>org.apache.hive</groupId>
<artifactId>hive-storage-api</artifactId>
</dependency>
+ <dependency>
+ <groupId>software.amazon.awssdk</groupId>
+ <artifactId>bundle</artifactId>
Review Comment:
I expect the major version to be updated when they explicitly introduce
breaking changes. However, the safety is not 100% guaranteed.
- https://github.com/aws/aws-sdk-java-v2/blob/master/VERSIONING.md
-
https://docs.aws.amazon.com/sdkref/latest/guide/maint-policy.html#maint-versioning
Specifically for `aws-secretmanager-caching-java`, I believe it is not tied
to a specific version, since its upgrades are handled by Dependabot.
- https://github.com/aws/aws-secretsmanager-caching-java/pull/179
As Hadoop recommends using the same version built for Hadoop, aligning with
S3A could be a safer option.
-
https://hadoop.apache.org/docs/r3.4.1/hadoop-aws/tools/hadoop-aws/troubleshooting_s3a.html#Classpath_Setup
Our choices:
- Use Hadoop's version, `2.29.52` used in Hadoop 3.4.2 or `2.35.4` used in
Hadoop 3.5.0. Could this be the safest?
- Use Secret Manager Caching's version, `2.41.3`
- Use another version, e.g., the latest version
As there is no perfect match, users may need to choose a single version
themselves.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
