soumyakanti3578 commented on code in PR #6383:
URL: https://github.com/apache/hive/pull/6383#discussion_r3018583056
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/tools/schematool/MetastoreSchemaTool.java:
##########
@@ -305,33 +299,22 @@ protected void execSql(String scriptDir, String
scriptFile) throws IOException,
execSql(scriptDir + File.separatorChar + scriptFile);
}
- // Generate the beeline args per hive conf and execute the given script
+ /**
+ * Executes the given SQL script file against the metastore database via
{@link IdempotentDDLExecutor}.
+ * Each statement in the script is executed individually over a direct JDBC
connection with
+ * auto-commit enabled. Errors that indicate an object already exists or is
already gone are
+ * silently ignored according to the per-database {@link DbErrorCodes}; all
other SQL errors are
+ * rethrown as {@link IOException}.
+ */
Review Comment:
I would want your opinion on this as I have limited knowledge about HMS in
general. What do you think? Ideally I think we would want idempotency for
HiveSchemaTool as well, and if you also think that we do, is it better to do it
as a follow-up?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
