ayushtkn commented on PR #6394: URL: https://github.com/apache/hive/pull/6394#issuecomment-4164011762
Only few tests failed, that means it isn't a Serialized table at all times. We might do a fallback thing as well only in case it is a SerializedTable or even change it in deserializeTable to return the `BaseTable`, but since I don't want to rearchitect in this scope, I would keep my scope as original. I would definitely avoid without being very sure of changes which I am not very confident, definitely not here & warrant some issue in trying to over optimize I will bug Simhadri as well, he was the last one to deal with concurrency in Iceberg for this change, If he is ok with this, obviously if he has time :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
