deniskuzZ commented on code in PR #6390:
URL: https://github.com/apache/hive/pull/6390#discussion_r3011267364


##########
packaging/src/docker/docker-compose.yml:
##########
@@ -88,14 +96,171 @@ services:
       - '10002:10002'
     volumes:
       - warehouse:/opt/hive/data/warehouse
+      - scratch:/opt/hive/scratch
+      # Mount local jars to a temporary staging area (Read-Only)
+      - ./jars:/tmp/ext-jars:ro
+    networks:
+      - hive
+
+  hiveserver2-llap:

Review Comment:
   could we merge the definitions?
   ````
    hiveserver2:
     image: apache/hive:${HIVE_VERSION}
     container_name: hiveserver2
     hostname: hiveserver2
     depends_on:
       - metastore
     restart: unless-stopped
   
     environment:
       USER: hive
       HADOOP_CLASSPATH: /opt/hadoop/share/hadoop/tools/lib/*
       HIVE_SERVER2_THRIFT_PORT: 10000
   
       HIVE_SCRATCH_DIR: /opt/hive/scratch
       HIVE_QUERY_RESULTS_CACHE_DIRECTORY: /opt/hive/scratch/_resultscache_
   
       SERVICE_NAME: 'hiveserver2'
       IS_RESUME: 'true'
   
       # Base SERVICE_OPTS without LLAP
       SERVICE_OPTS: >-
         -Xmx1G
         -Dhive.metastore.uris=thrift://metastore:9083
         -Dhive.execution.engine=tez
   
       S3_ENDPOINT_URL: "${S3_ENDPOINT_URL}"
       AWS_ACCESS_KEY_ID: "${AWS_ACCESS_KEY_ID}"
       AWS_SECRET_ACCESS_KEY: "${AWS_SECRET_ACCESS_KEY}"
   
     ports:
       - "10000:10000"
       - "10002:10002"
   
     volumes:
       - warehouse:/opt/hive/data/warehouse
       - scratch:/opt/hive/scratch
       - ./jars:/tmp/ext-jars:ro
   
     networks:
       - hive
   
     # Add profile-specific override for LLAP
     profiles: [default, llap]
   
   
   hiveserver2-llap-env:
     profiles: [llap]
     environment:
       SERVICE_OPTS: >-
         -Xmx1G
         -Dhive.metastore.uris=thrift://metastore:9083
         -Dhive.execution.engine=tez
         -Dhive.execution.mode=llap
         -Dhive.llap.execution.mode=all
         -Dhive.zookeeper.quorum=zookeeper:2181
         -Dhive.llap.daemon.service.hosts=@llap0
   ````
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to