ayushtkn commented on code in PR #6394:
URL: https://github.com/apache/hive/pull/6394#discussion_r3008320965
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java:
##########
@@ -440,7 +440,7 @@ private void commitTable(FileIO io, ExecutorService
executor, OutputTable output
for (JobContext jobContext : jobContexts) {
JobConf conf = jobContext.getJobConf();
- table = Optional.ofNullable(table).orElseGet(() ->
Catalogs.loadTable(conf, catalogProperties));
+ table = Optional.ofNullable(table).orElseGet(() ->
IcebergTableUtil.getTable(conf, catalogProperties));
Review Comment:
should it not break at time of commit? if our commit is conflicting? Means
this is again reloading the table & reading the metadata which we already read
once.
Between this and before we commit there could be another commit which could
create conflict. I don't think we are under lock
In that case I believe some test would fail....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
