deniskuzZ commented on code in PR #6379:
URL: https://github.com/apache/hive/pull/6379#discussion_r3001305914
##########
ql/src/java/org/apache/hadoop/hive/llap/ProactiveEviction.java:
##########
@@ -152,19 +153,20 @@ public void run() {
}
/**
- * Holds information on entities: DB name(s), table name(s), partitions.
+ * Holds information on entities: catalog name(s), DB name(s), table
name(s), partitions.
*/
public static final class Request {
- // Holds a hierarchical structure of DBs, tables and partitions such as:
- // { testdb : { testtab0 : [], testtab1 : [ {pk0 : p0v0, pk1 : p0v1}, {pk0
: p1v0, pk1 : p1v1} ] }, testdb2 : {} }
- private final Map<String, Map<String, Set<LinkedHashMap<String, String>>>>
entities;
+ // Holds a hierarchical structure of catalogs, DBs, tables and partitions
such as:
+ // { hive : { testdb : { testtab0 : [], testtab1 : [ {pk0 : p0v0, pk1 :
p0v1} ] }, testdb2 : {} } }
+ // The catalog key defaults to Warehouse.DEFAULT_CATALOG_NAME ("hive")
when no explicit catalog is given.
+ private final Map<String, Map<String, Map<String,
Set<LinkedHashMap<String, String>>>>> entities;
Review Comment:
can we refactor
````
record PartitionSpec(Map<String,String> spec) {}
Map<String, Map<String, Map<String, Set<PartitionSpec>>>> entities;
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
