abstractdog commented on code in PR #6386:
URL: https://github.com/apache/hive/pull/6386#discussion_r2987064659
##########
ql/src/java/org/apache/hadoop/hive/ql/DriverContext.java:
##########
@@ -275,8 +275,4 @@ public void setExplainPlan(String explainPlan) {
public String getExplainPlan() {
return explainPlan;
}
-
- public void recordQueryStartTime() {
- plan.setQueryStartTime(queryDisplay.getQueryStartTime());
Review Comment:
if you remove this, the only usage of `plan.setQueryStartTime()` is from
`TestHiveProtoLoggingHook`, does it make sense to add `@VisibleForTesting` to
`setQueryStartTime` to let the code readers know that they should not set this
directly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
