zabetak commented on code in PR #6371:
URL: https://github.com/apache/hive/pull/6371#discussion_r2986702990
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java:
##########
@@ -1100,17 +1101,11 @@ public static String[] parseDbName(String dbName,
Configuration conf) throws Met
return Arrays.copyOf(nullCatalogAndDatabase,
nullCatalogAndDatabase.length);
}
if (hasCatalogName(dbName)) {
- if (dbName.endsWith(CATALOG_DB_SEPARATOR)) {
- // This means the DB name is null
- return new String[] {dbName.substring(1, dbName.length() - 1), null};
- } else if (dbName.endsWith(DB_EMPTY_MARKER)) {
- // This means the DB name is empty
- return new String[] {dbName.substring(1, dbName.length() -
DB_EMPTY_MARKER.length() - 1), ""};
- }
String[] names = dbName.substring(1).split(CATALOG_DB_SEPARATOR, 2);
- if (names.length != 2) {
- throw new MetaException(dbName + " is prepended with the catalog
marker but does not " +
- "appear to have a catalog name in it");
Review Comment:
Since you removed the exception you have to update the signature of the
method and the Javadoc as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
