okumin commented on code in PR #6387:
URL: https://github.com/apache/hive/pull/6387#discussion_r2971297671
##########
.github/workflows/docker-images.yml:
##########
@@ -87,10 +89,21 @@ jobs:
- name: Prepare common environment variables
run: |
echo "namespace=${{ vars.DOCKER_NAMESPACE || 'apache' }}" >>
$GITHUB_ENV
- echo "tag=$HIVE_VERSION" | awk '{print tolower($0)}' >> $GITHUB_ENV
+ echo "tag=$HIVE_VERSION" >> $GITHUB_ENV
Review Comment:
I believe we don't have a case where we have to keep the `tolower`.
Also, this PR currently assumes we want to replace `4.3.0-SNAPSHOT` and
`standalone-metastore-4.3.0-SNAPSHOT` every day. I'd say it is a good starting
point; we can add the date or checksum later if we want.
##########
.github/workflows/docker-images.yml:
##########
@@ -18,6 +18,8 @@ name: Build and Publish docker images for Hive GA
on:
create:
+ schedule:
+ - cron: '17 3 * * *'
Review Comment:
I chose an odd time, following [the
guidance](https://docs.github.com/en/actions/reference/workflows-and-actions/events-that-trigger-workflows#schedule).
> The schedule event can be delayed during periods of high loads of GitHub
Actions workflow runs. High load times include the start of every hour. If the
load is sufficiently high enough, some queued jobs may be dropped. To decrease
the chance of delay, schedule your workflow to run at a different time of the
hour.
##########
itests/test-docker/k8s/hive-metastore/deployment.yaml:
##########
@@ -40,7 +40,7 @@ spec:
- |
apt-get update
apt-get install -y --no-install-recommends ca-certificates wget
- wget
https://repo1.maven.org/maven2/software/amazon/awssdk/bundle/2.26.19/bundle-2.26.19.jar
-P /tmp/ext-jars
+ wget
https://repo1.maven.org/maven2/software/amazon/awssdk/bundle/2.41.3/bundle-2.41.3.jar
-P /tmp/ext-jars
Review Comment:
I guess [this patch] brought a new library.
https://github.com/apache/hive/pull/6167
Should we rather exclude `aws-java-sdk-secretsmanager` from
`aws-secretsmanager-caching-java`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
