arnoudja commented on code in PR #1851:
URL: https://github.com/apache/activemq/pull/1851#discussion_r3005979990
##########
activemq-client/src/main/java/org/apache/activemq/command/ActiveMQTextMessage.java:
##########
@@ -182,15 +181,22 @@ public void clearBody() throws JMSException {
@Override
public int getSize() {
+ int minimumMessageSize = getMinimumMessageSize();
+ ByteSequence content = this.content;
String text = this.text;
- if (size == 0 && content == null && text != null) {
- size = getMinimumMessageSize();
- if (marshalledProperties != null) {
- size += marshalledProperties.getLength();
- }
+
+ size = minimumMessageSize;
+ if (marshalledProperties != null) {
+ size += marshalledProperties.getLength();
+ }
+ if (content != null) {
+ size += content.getLength();
+ }
+ if (text != null) {
size += text.length() * 2;
}
- return super.getSize();
+
+ return size;
Review Comment:
Thanks for pointing that out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
