jeanouii commented on PR #1543: URL: https://github.com/apache/activemq/pull/1543#issuecomment-4053934941
LGTM Type validation prior to consumption - enqueue first if not good. Better approach than consuming and catching exception because then you would need remove from deliveredMessages when AUTO_ACK before doing the enqueue first. TRANSACTED/CLIENT_ACK call to before and after to manage the credit window. Avoid blocking the next receive. Test coverage looks good with edge cases for credit window expansion, transacted rollback, auto_ack redelivery, plain message. Good job @jbonofre -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
