cshannon commented on PR #1728: URL: https://github.com/apache/activemq/pull/1728#issuecomment-3992562857
This will need to be reviewed in detail, there were problems with the previous attempt to address this in https://github.com/apache/activemq/pull/1364 with not meeting the spec One of the biggest issues as commented [here](https://github.com/apache/activemq/pull/1364#issuecomment-2535866454) was this part of the spec: https://jakarta.ee/specifications/messaging/3.1/jakarta-messaging-spec-3.1#use-of-the-completionlistener-by-the-jakarta-messaging-provider >7.3.8. Use of the CompletionListener by the Jakarta Messaging provider A session will only invoke one CompletionListener callback method at a time. For a given MessageProducer or JMSContext, callbacks (both onCompletion and onException) will be performed in the same order as the corresponding calls to the asynchronous send method. @jeanouii - I haven't reviewed this yet but does this PR address that part (7.3.8) of the spec? Have you reviewed the other parts of the spec to verify if this is compatible? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
