jeanouii commented on PR #1659: URL: https://github.com/apache/activemq/pull/1659#issuecomment-3885955879
> In the past I have also noticed some odd behavior with the VM transport when using clients (producers/consumers) that could be a thread safety bug (it is used for bridges though and seems fine there so that is interesting). > > However, this proposed fix in this PR doesn't make sense to me at all because the entire point is to NOT need to marshal the message. If you want to marshal the object then you should just use the TCP transport as you lose the benefits. > > The VM transport is supposed to already do a deep copy during dispatch to prevent issues with multi-threading. It's possible there is an issue with that, so that's probably where to look for a fix vs adding in marshaling. > > Here is where the copying is doing on dispatch in the connection: > > https://github.com/apache/activemq/blob/a8fa4b09b54eaca06d106e754796798bd88e21e9/activemq-client/src/main/java/org/apache/activemq/ActiveMQConnection.java#L1906-L1929 > > I would start there as to investigating if that is the issue Thanks for the background @cshannon -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
