mattrpav commented on code in PR #1247:
URL: https://github.com/apache/activemq/pull/1247#discussion_r1828513681
##########
activemq-unit-tests/src/test/java/org/apache/activemq/broker/virtual/VirtualTopicSelectorTest.java:
##########
@@ -99,7 +103,25 @@ protected BrokerService createBroker() throws Exception {
virtualTopic.setSelectorAware(true);
VirtualDestinationInterceptor interceptor = new
VirtualDestinationInterceptor();
interceptor.setVirtualDestinations(new
VirtualDestination[]{virtualTopic});
- broker.setDestinationInterceptors(new
DestinationInterceptor[]{interceptor});
+ TestDestinationInterceptor testInterceptor = new
TestDestinationInterceptor();
Review Comment:
Instead of modifying the existing test, please add a second test to cover
the new use case. Changing the test removes the test for the out-of-the-box
default behavior vs the custom behavior this fix solves.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
