tabish121 commented on code in PR #5152:
URL: https://github.com/apache/activemq-artemis/pull/5152#discussion_r1719843024
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/group/impl/LocalGroupingHandler.java:
##########
@@ -322,11 +322,19 @@ public synchronized void start() throws Exception {
if (started)
return;
- if (expectedBindings == null) {
- // just in case the component is restarted
- expectedBindings = new LinkedList<>();
+ try
+ {
+ lock.lock();
Review Comment:
The attempt to lock is normally placed outside the try as you don't want the
finally to attempt to unlock a lock if the caller fails to acquire the lock in
the first place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
