gaohoward commented on PR #5128: URL: https://github.com/apache/activemq-artemis/pull/5128#issuecomment-2285249462
> To be honest, given the uglyness from not applying the settings but then only logging about it, and the other uglyness from throwing (potentially preventing other valid settings being applied)... > > I find myself wondering if this should either just be doc-only and left working the way it was...or else, adding the doc changes and just a log message to indicate setting pageLimit < pageSize will cause immediate block, but no 'dont apply these settings' step so there is no unexpected knock on effects. Yeah make sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
