gemmellr commented on code in PR #5128:
URL: https://github.com/apache/activemq-artemis/pull/5128#discussion_r1705664759


##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQMessageBundle.java:
##########
@@ -559,4 +560,6 @@ IllegalStateException invalidRoutingTypeUpdate(String 
queueName,
    @Message(id = 229255, value = "Bridge {} cannot be {}. Current state: {}")
    ActiveMQIllegalStateException bridgeOperationCannotBeExecuted(String 
bridgeName, String failedOp, BridgeImpl.State currentState);
 
+   @Message(id = 229256, value = "Invalid address settings {} for page store 
{}. Details: {}")
+   ActiveMQException invalidPageSettings(String pageStoreName, AddressSettings 
addressSettings, String details);

Review Comment:
   Perhaps, but it seemed more like it should be getting used hehe, e.g in the 
constructor scenario from my other comment :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to