gemmellr commented on code in PR #5127:
URL: https://github.com/apache/activemq-artemis/pull/5127#discussion_r1705276839
##########
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/Create.java:
##########
@@ -77,6 +77,7 @@ public class Create extends InstallAbstract {
public static final String BIN_ARTEMIS_SERVICE = "bin/" + ARTEMIS_SERVICE;
public static final String ETC_ARTEMIS_PROFILE = "artemis.profile";
public static final String ETC_LOG4J2_PROPERTIES = "log4j2.properties";
+ public static final String ETC_LOG4J2_DEFAULT_PROPERTIES =
"log4j2-default.properties";
Review Comment:
My point is that it feels like 'log4j2-default' isnt a very clear
descriptive name for everyone else and could easily be misunderstood. I know
that we will understand what its for, but it seems like something others could
misinterpret, i.e those who havent seen the Jira/this discussion/this PR to
understand exactly why that file is being created and what that file is not
used for. Especially when in actual Log4J2 terms the existing log4j2.properties
is actually 'the default file' (to Log4J it is the highest preendence non-test
configuration file, and what will get used if you dont specify
-Dlog4j2.configurationFile=foo). Something more descriptive of its usage like
e.g log4j2-tools/utilities/foo.properties makes more explicit what the file is
being aimed at than just a '-default' suffix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
