gemmellr commented on code in PR #4830:
URL: https://github.com/apache/activemq-artemis/pull/4830#discussion_r1502597844
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/metrics/MetricsManager.java:
##########
@@ -86,6 +87,9 @@ public MetricsManager(String brokerName,
if (metricsConfiguration.isUptime()) {
new UptimeMetrics().bindTo(meterRegistry);
}
+ if (metricsConfiguration.isLogging()) {
+ new Log4j2Metrics().bindTo(meterRegistry);
+ }
Review Comment:
Given the broker as a whole is not really tied to Log4j2 (but rather SLF4J
API), it actually feels a little weird that this is. Especially as the broker
(or micrometer) has no [passed-on] dependency on Log4J2, so this wont work in
some cases. The config doc should perhaps be clearer that it is
Log4j2-specific, and perhaps note that such a dependency would need to be
provided if enabling this while e.g embedding / not using the distribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
