Michael J Gruber <[email protected]> wrote:
> A few changelog entries have inconsistent dates, which rpmlint reports
> as errors.
>
> Fix them based on these assumptions:
> - It's easier to mistype a number than a weekday abbreviation.
> - changelog date must be before git commit date
> - The mistyped date is just a few days off.
>
> Signed-off-by: Michael J Gruber <[email protected]>
> ---
> I dunno if this is worthwhile, but rpmlint is the first thing we tell
> packagers and reviewers to check.
>
> git.spec.in | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/git.spec.in b/git.spec.in
> index bfd1cfb..eb581a3 100644
> --- a/git.spec.in
> +++ b/git.spec.in
> @@ -229,7 +229,7 @@ rm -rf $RPM_BUILD_ROOT
> * Sat Jan 30 2010 Junio C Hamano <[email protected]>
> - We don't ship Python bits until a real foreign scm interface comes.
>
> -* Mon Feb 04 2009 David J. Mellor <[email protected]>
> +* Mon Feb 02 2009 David J. Mellor <[email protected]>
> - fixed broken git help -w after renaming the git-core package to git.
>
> * Fri Sep 12 2008 Quy Tonthat <[email protected]>
> @@ -262,7 +262,7 @@ rm -rf $RPM_BUILD_ROOT
> * Thu Jun 21 2007 Shawn O. Pearce <[email protected]>
> - Added documentation files for git-gui
>
> -* Tue May 13 2007 Quy Tonthat <[email protected]>
> +* Sun May 13 2007 Quy Tonthat <[email protected]>
It is inconsistent with what you said in the commit message ("It's
easier to mistype a number than a weekday abbreviation.").
Following that logic, it should be:
* Tue May 15 2007 Quy Tonthat <[email protected]>
(or 08, I didn't check the condition "changelog date must be before
git commit date")
Thanks,
Rémi
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
