On Mon, Apr 4, 2016 at 1:01 PM, Matthieu Moy <[email protected]> wrote: > Mehul Jain <[email protected]> writes: > >> -test_rebase_autostash () { >> +test_pull_autostash () { >> git reset --hard before-rebase && >> echo dirty >new_file && >> git add new_file && >> - git pull --rebase --autostash . copy && >> + git pull $@ . copy && > > Not strictly needed here, but I'd write "$@" (with the double-quotes) > which is the robust way to say "transmit all my arguments without > whitespace interpretation". > > I don't mind for this patch since there's no whitespace to interpret, > but some people (sysadmins ;-) ) have the bad habit of writting $@, $* > or "$*" in wrapper scripts and it breaks when you call them with spaces > so it's better to take good habits IHMO.
Thanks for the suggestion, I will remember it. I'm relatively new to shell and therefore didn't know much about the difference between "$@" and $@, $*, "$*". Now that I have read[1][2] about it, it won't be repeated. [1]: http://unix.stackexchange.com/questions/41571/what-is-the-difference-between-and/94200#94200 [2]: http://unix.stackexchange.com/questions/131766/why-does-my-shell-script-choke-on-whitespace-or-other-special-characters Thanks, Mehul -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
