This series deals with strbuf_getline_lf() in certain codepaths:
Those, where the input that is read, is/was trimmed before doing anything that
could possibly expect a CR character. Those places can be assumed to be "text"
input, where a CR never would be a meaningful control character.
The purpose of this series is to document these places to have this property,
by using strbuf_getline() instead of strbuf_getline_lf(). Also in some
codepaths,
the CR could be a leftover of an editor and is thus removed.
Every codepath was examined, if after the change it is still necessary to have
trimming or if the additional CRLR-removal suffices.
The series is an idea out of [1], where Junio proposed to replace the calls
to strbuf_getline_lf() because it 'would [be] a good way to document them as
dealing with "text"'.
Changes since v1:
* adapting the behaviour of sq_(de)quote to be a one-to-one transformation
* removing some unneccesary trimming calls in:
* wt-status.c
* builting/notes.c
* builtin/clean.c
* bisect.c
-Moritz
[1] http://thread.gmane.org/gmane.comp.version-control.git/284104
Moritz Neeb (6):
quote: remove leading space in sq_dequote_step
bisect: read bisect paths with strbuf_getline()
clean: read user input with strbuf_getline()
notes: read copied notes with strbuf_getline()
remote: read $GIT_DIR/branches/* with strbuf_getline()
wt-status: read rebase todolist with strbuf_getline()
bisect.c | 5 ++---
builtin/clean.c | 12 +++---------
builtin/notes.c | 3 +--
quote.c | 2 ++
remote.c | 2 +-
wt-status.c | 3 +--
6 files changed, 10 insertions(+), 17 deletions(-)
--
2.7.1.345.gc14003e
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
