On Thu, Feb 18, 2016 at 03:33:16PM -0800, Stefan Beller wrote:
> + if (needs_cloning) {
> + cp->git_cmd = 1;
> + cp->no_stdin = 1;
> + cp->stdout_to_stderr = 1;
> + cp->err = -1;
> + argv_array_push(&cp->args, "submodule--helper");
> + argv_array_push(&cp->args, "clone");
> + if (pp->quiet)
> + argv_array_push(&cp->args, "--quiet");
> +
> + if (pp->prefix)
> + argv_array_pushl(&cp->args, "--prefix", pp->prefix,
> NULL);
> +
> + argv_array_pushl(&cp->args, "--path", sub->path, NULL);
> + argv_array_pushl(&cp->args, "--name", sub->name, NULL);
> + argv_array_pushl(&cp->args, "--url", strdup(url), NULL);
No need to strdup() here; argv_array handles its own memory, so this
just leaks (and if we were keeping it, it should be xstrdup(), of
course).
-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
