On Wed, Feb 10, 2016 at 1:54 PM, Jeff King <[email protected]> wrote: >> +--sources:: >> + Augment the output of all queried config options with the >> + source type (file, stdin, blob, cmd) and the actual source >> + (config file path, ref, or blob id if applicable). > > I think something like "cmdline" might be more descriptive than "cmd".
I agree "cmdline" is better than "cmd". > So the format here is like: > > file\t<filename>\t<value...> > blob\t<blob>\t<value...> > stdin\t\t<value...> > cmd\t\t<value...> > > where two of the prefixes have nothing in the second slot. I expected > something more like: > > file:<filename>\t</value...> > blob:<blob>\t<value...> > stdin\t<value...> > cmd\t<value...> > > with a single delimited slot for the source, which can then be broken > down further if desired. I can't think of any reason to prefer one over > the other rather than personal preference, though. They can both be > parsed unambiguously. I also would have expected sopme like the latter, except that I'd also expect a colon after "stdin" and "cmd" (or "cmdline", as said above). I.e. the colon should be part of the prefix to mark it as such. -- Sebastian Schuberth -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
