On Mon, Feb 08, 2016 at 01:00:50PM -0500, Eric Sunshine wrote: > On Mon, Feb 8, 2016 at 10:08 AM, Jeff King <[email protected]> wrote: > > On Mon, Feb 08, 2016 at 02:41:44PM +0000, Markus Kuhn wrote: > >> Suggested rephrasing: > >> > >> If not set, the value of transfer.fsckObjects is used > >> instead, which defaults to false. > > > > Yeah, I agree your phrasing is much clearer. > > Should we worry about this becoming outdated if the default of > transfer.fsckObjects ever changes, or is that being overcautious? If > it is a legitimate concern, then perhaps drop "which defaults to > false" from the end of the sentence.
I agree that is a potential maintenance pitfall, but I think it is outweighed by the benefit: namely that the information the user wants is right there, without them having to cross-reference themselves. Flipping the default for transfer.fsckObjects would hopefully cause us to examine matching fetch.*, and we would notice this during review. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
