"Rainer M. Canavan" <[email protected]> writes: > Subject: Re: [PATCH] In configure.ac, try -lpthread in $LIBS instead of > $CFLAGS to make picky linkers happy
The patch looks good, but the subject should be improved. We normally try to stick to 50 characters (to let "git log --oneline" fit in a 80 columns terminal). 50 is a bit strict and not always followed, but yours is definitely too long. Also, the convention is "subsystem: what you did". I'd suggest this: configure.ac: try -lpthread in $LIBS instead of $CFLAGS The "to make picky linkers happy" is important, but redundant with the body of the message. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
