Tobias Klauser <tklau...@distanz.ch> writes: > Also switch all current users of stripspace() to the new function name > and keep a temporary wrapper inline function for topic branches still > using stripspace().
Since you have this temporary wrapper, it would have made sense to split the patch into 1) move and rename the function, and 2) change the callsites to strbuf_stripspace. This way 2) would be absolutely trivial to review. OTOH, this patch is already easy to review, so you may consider it's OK like this. Reviewed-by: Matthieu Moy <matthieu....@imag.fr> -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
