Ok, this may not be new either, but I'm trying to be careful when
using "git am" these days, because I know it got rewritten.
And I _think_ the whitespace handling for adding sign-offs got scrogged.
I just applied the usual patch-bomb from Andrew, and several of the
commits (but not all) end up looking like this:
Cc: <[email protected]> [3.15+]
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
note the extraneous whitespace line between Andrew's sign-off and mine.
What's odd is that the emails I'm applying literally don't have that
extra empty line, so it's git that somehow decides to add it. Only
for a few cases, though.
The pattern *seems* to be that git now looks at the *first* line of
the sign-off block and decides that "this is a sign-off block if that
first line has a sign-ff on it, ie this is fine:
Signed-off-by: Andrea Arcangeli <[email protected]>
Cc: Pavel Emelyanov <[email protected]>
Cc: Dave Hansen <[email protected]>
Cc: Linus Torvalds <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
but the failing cases have a comment by Andrew:
[[email protected]: coding-style fixes]
Signed-off-by: Tang Chen <[email protected]>
Cc: Xishi Qiu <[email protected]>
Cc: Yasuaki Ishimatsu <[email protected]>
Cc: Kamezawa Hiroyuki <[email protected]>
Cc: Taku Izumi <[email protected]>
Cc: Gu Zheng <[email protected]>
Cc: Naoya Horiguchi <[email protected]>
Cc: Vlastimil Babka <[email protected]>
Cc: Mel Gorman <[email protected]>
Cc: David Rientjes <[email protected]>
Cc: <[email protected]> [4.2.x]
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
ie that "[[email protected]: coding-style fixes]" makes git am
now decide that the previous block of text was not a sign-off block,
so it adds an empty line before adding my sign-off. But very obviously
it *was* a sign-off block.
Maybe this isn't new at all, and it's just that I notice because I'm
looking for "git am" oddities. Something is clearly wrong in
"has_conforming_footer()".
I *think* it's this part:
if (!(found_rfc2822 ||
is_cherry_picked_from_line(buf + i, k - i - 1)))
return 0;
which basically returns 0 for _any_ line in the footer that doesn't
match the found_rfc2822 format.
I really think that if we find any "Signed-off-by:" in that last
chunk, we should not add a whitespace.
Comments?
Linus
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
