Jonathan Nieder <[email protected]> writes:

>> would there be interest in accepting a patch for 
>>
>> %Gs - the raw GPG text from the commit
>> %Gf - the key fingerprint
>
> There may be bikeshedding on the exact format specifier, but aside
> from that I don't see why not. ;-)

I was about to say "As long as the execution is good, why not?
Spawning an extra process 'gpg --list-packets' is not quite
acceptable without properly being lazy is not acceptable".

But verify_signed_buffer() reads "gpg --status-fd=1 --verify"
output, it is already done lazily in format_commit_one() only when
the "%G?" placeholder is used, and the output we parse that are
prefixed by [GNUPG:] should have enough information to grab the
fingerprint from on the VALIDSIG line.

So I do not see a lot of room to screw-up the execution ;-).


--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to