On Aug 19, 2014, at 9:53 AM, Jeff King <[email protected]> wrote:
>>> For files >2GB on a 32-bit system (e.g. msysgit), filtering with the
>>> previous code always failed. Now it works. I created the patch to
>>> change git from 'fundamentally doesn't handle this' to 'works as
>>> expected'.
>>
>> I deal with similar problem and added $GIT_ALLOC_LIMIT to test large
>> blob code. Maybe we could add $GIT_MMAP_LIMIT? I don't suppose we call
>> xmmap/xmalloc so often that the extra test would slow git down.
>
> Yeah, I think I'd prefer that approach. We should mmap _way_ less than
> we malloc, and I do not think the malloc check has caused any problems.
I am going to update the patch accordingly.
Steffen
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html